Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a line break to kubectl-moco start/stop command's message #737

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

masa213f
Copy link
Contributor

@masa213f masa213f commented Sep 6, 2024

Signed-off-by: Masayuki Ishii [email protected]

Copy link
Member

@ymmt2005 ymmt2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you just use fmt.Fprintln?

Since all of these output to os.Stdout, we can even use fmt.Println.

Signed-off-by: Masayuki Ishii <[email protected]>
@masa213f
Copy link
Contributor Author

masa213f commented Sep 6, 2024

@ymmt2005
That's true. fixed.

Copy link
Member

@ymmt2005 ymmt2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masa213f masa213f merged commit 4c3ec5d into main Sep 6, 2024
17 checks passed
@masa213f masa213f deleted the update-20240906 branch September 6, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants